Greg KH <[EMAIL PROTECTED]> writes: > On Thu, Jul 13, 2006 at 10:20:19PM +0400, Sergei Organov wrote: [...] >> Besides, if the throttle() is that important and failure to handle it is >> a big mistake, why is it optional then? I mean why struct tty_operations >> with throttle field set to NULL is accepted in the first place? The same >> question is applicable to the struct usb_serial_driver. > > Yes, I didn't realize it was required.
That was my point, -- people don't realize it is dangerous not to handle throttle, and in fact it was not that dangerous before new tty buffering has been implemented. I do handle throttle in my driver, but it has been implemented as a part of work-around for the deficiencies of the old tty buffering. I seriously doubt I'd realize it's a must to honour throttle should I start to write the driver today. -- Sergei. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
