>>>>> "David" == David Brownell <[EMAIL PROTECTED]> writes:
>> I get the feeling that your patch does much more testing for >> -ENODEV than necessary, and likewise for calls to >> netif_device_detach(). David> Paranoia? :) Indeed. >> Do you really have to call that routine from anywhere but the >> disconnect() method? Yes... David> That routine is how the network layer knows not to send packets David> to/from an interface any more. When the new David> class.suspend()/class.resume() methods go upstream, those calls David> can/should be made by the network core; but until then, every David> driver needs to have those calls. David> ... in fact, it'd be a good thing to convert rtl8150 to run in David> that driver framework, much like asix.c does already. You'd David> probably get better throughput too. That's only if you have David> the time... :) We need to deploy 30 of this device on Friday. I needed to get it going and a bit more robust fast. Please, can others who understand the problem better do a better fix? This one gets us going for now -- Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au http://www.ertos.nicta.com.au ERTOS within National ICT Australia ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
