On Sat, 29 Jul 2006, Thiago Galesi wrote:

> On 7/29/06, Pete Zaitcev <[EMAIL PROTECTED]> wrote:
> > On Fri, 28 Jul 2006 10:25:32 -0300, "Thiago Galesi" <[EMAIL PROTECTED]> 
> > wrote:
> >
> > > Fixes several lines that overrun 80 columns in Prolific pl2303 driver
> >
> > > -     usb_serial_debug_data(debug, &port->dev, __FUNCTION__, count,
> > > port->write_urb->transfer_buffer);
> > > +     usb_serial_debug_data(debug, &port->dev, __FUNCTION__, count
> > > +                          , port->write_urb->transfer_buffer);
> >
> > Are you out of your mind?
> 
> Sigh. Different editors show this differently. vi here shows ", port"
> aligned with "(debug". Yes, this is not correct.

I think Pete was referring to the way you put the "," character on the 
continuation line instead of at the end of the first line.  People expect 
to see code formatted like this:

        usb_serial_debug_data(debug, &port->dev, __FUNCTION__, count,
                        port->write_urb->transfer_buffer);

The exact amount of indentation on the continuation line is subject to a 
certain amount of variation and personal taste.

Alan Stern


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to