On Sunday 30 July 2006 03.34, Dmitry Torokhov wrote:
> Hi Daniel,
> 
> On Saturday 29 July 2006 18:38, Daniel Ritz wrote:
> 
> > - always do usb_submit_urb(dev->irq) in probe() to work around issues
> > with some eGalaxe contollers
> 
> Could you elaborate on the issues you are seeing? Submitting URB in
> ->open() basically just delays it, that's all. 
> 

there was a report from a user who saw a series of disconnect/connect
until X11 was started up. and of course most of the time the device
was disconnected when X11 fired up. the workaround he found was doing
        cat /dev/input/event3 > /dev/null 2>&1 &
immediately after the touchscreen was detected. this prevented the device
from doing those disconnect/connects...ie. as soon as some process has the
event interface open the touchscreen is stable.

> > +out_unregister:
> > +       input_unregister_device(usbtouch->input);
> > +
> >  out_free_buffers:
> >         usbtouch_free_buffers(udev, usbtouch);
> >  out_free:
> >         input_free_device(input_dev);
> >         kfree(usbtouch);
> > 
> 
> It is not allowed to simply call input_free_device() after calling
> input_unregister_device(). Either take an extra reference with
> input_get_device() or just add "input_dev = NULL;" after calling
> input_unregister_devive() - input_free_device() handles NULLs just
> fine.

oops, yes. will set it to NULL.

thanks, rgds
-daniel

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to