On Mon, 31 Jul 2006, Duncan Sands wrote: > > No, this patch won't apply to 2.6.17 -- it's 2.6.18 only. There was a > > separate patch (as753) already submitted for 2.6.17-stable. > > OK, then that means that yet another patch is needed for 2.6.17! Here's > a summary of the situation. This patch for 2.6.17 > http://bugzilla.kernel.org/attachment.cgi?id=8591&action=view > (which I presume is a753)
Yes. > fixed hangs for cdc_ether modems. However > it didn't fix the speedtouch hangs with 2.6.17. Are you sure? The logs you attached to the bug report were all from 2.6.18. I don't remember seeing any indications that you had failures with the speedtouch in 2.6.17. The problems fixed by the two patches are really separate, albeit closely related. The 2.6.17 code wasn't checking at all whether the TD was the last in the URB. The 2.6.18 code was checking the SPD bit (which the driver sets to 0 in the last TD, but apparently the controller changes it) instead of checking whether the TD was the last in the URB. The patches made the two driver versions do the same thing: always check the TD's position in the URB's list. > Those also occur in > 2.6.18 (though are much harder to hit due to the FSBR changes). You can revert the FSBR timing patch for testing. It's independent of everything else. < Your > patch as759 fixes the speedtouch problem with 2.6.18. However it > doesn't apply to 2.6.17, so another fix is needed there. I'm about > to disappear for around two weeks, so further testing of 2.6.17 will > unfortunately have to wait till I get back. Okay, I'll wait until you can do more testing. But for now it seems pretty clear that patches as753 and as759 are both necessary, even if not sufficient. Alan Stern ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
