--- Alan Stern <[EMAIL PROTECTED]> wrote:
> On Mon, 31 Jul 2006, Aleksey Gorelov wrote: > > > If some problem occurs during ehci startup, for instance, request_irq > > fails, echi hcd driver > > tries it best to cleanup, but fails to unregister reboot notifier, which in > > turn leads to > crash on > > reboot/poweroff. The following patch resolves this problem by not using > > reboot notifiers > anymore, > > but instead making ehci/ohci driver get its own shutdown method. For PCI, > > it is done through > pci > > glue, for everything else through platform driver glue. > > Why do you need to change the bus glue? Wouldn't it be a lot simpler just > to add ehci_shutdown as a member of ehci_pci_driver, for instance, with > similar changes to ehci_hcd_au1xxx_driver and ehci_hcd_fsl_driver? > > Alan Stern This avoids code duplication for common for both ehci and ohci code (and possibly for uhci, but it currently does not have any notifier/shutdown handler), and is consistent with other functions there. Aleks. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
