On Monday 07 August 2006 16:54, David Hollis wrote:
> These values are dupes of the MII_xxxx constants from linux/mii.h. It
> would be clearer and more consistent to use those instead
ok
> These values are device specific so you would want to define them here.
> Following the MII_xxxxx naming convention may be helpful.
ok
> > +
> > +static DEFINE_MUTEX(mcs7830_phy_mutex);
> > +
>
> Does this need to be global? Isn't it really just to prevent
> simultaneous access to the adapters PHY? What if you have multiple
> adapters installed?
It's very rarely held, so I don't expect this to be a bottleneck,
even with a large number of adapters.
The implementation is slightly simpler this way, but I can move
the mutex to struct usbnet instead if you prefer.
> > + dev->in = usb_rcvbulkpipe(dev->udev, 1);
> > + dev->out = usb_sndbulkpipe(dev->udev, 2);
>
> Couldn't you use usbnet_getendpoints() here. It will also pick up the
> status pipe.
Yes. usbnet_getendpoints() didn't work at first, but I think
I found the problem with it now. I'll change that once I
have the interrupts sorted out.
> use MII_BMSR here instead of the magic value '1'.
ok
Arnd <><
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
