On Monday 14 August 2006 7:54 pm, Pete Zaitcev wrote: > On Tue, 1 Aug 2006 08:17:51 -0700, David Brownell <[EMAIL PROTECTED]> wrote: > > > However a "grep ETIMEDOUT drivers/usb/*/*.[hc]" shows more than HID > > needs to change, you should update all the relevant drivers not > > just that one ... e.g. other input drivers and the network drivers > > are all pretty good about robust fault recovery and this change > > would cause breakage if you don't fix those too. > > I do not agree with your statement about the robust fault recovery. > In fact, the vast majority of drivers are written poorly, which > bites especially when they start using interrupt or ISO transfers.
Which is why I started to make e.g. "usbnet" do the Right Thing with respect to fault recovery, and have been working (over time) on getting similar updates into other drivers. And which is also why it bothered me particularly to see your patch break drivers which were previously doing the Right Thing. It's rather important that the few drivers that do the Right Thing keep doing that. > Only those drivers which get attention from Alan or Greg are more > or less ok, e.g. usb-storage and hid - which I fixed the first > time around. And "usbnet". I translated a few of those usbnet fault recovery schemes into HID a few years back -- but not all of them. Storage has a few unique problems. I'm rather surprised you mention HID as getting much attention; it's always seemed to me to be pretty much of an orphan, lucky to get the occasional critical bugfix. > However, I see that I didn't do the due dilligence, and a replacement > is needed in a few more places, notably in input/. Please see attached > (cumulative). Thanks, I'll review later when I have some time. - Dave ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
