On Mon, 14 Aug 2006 15:22:10 +0200 Aurelien Jarno wrote:
> Hi!
>
> On Tue, Aug 08, 2006 at 06:36:30PM +0200, Aurelien Jarno wrote:
> > On Tue, Aug 08, 2006 at 02:22:24PM +0200, Thomas Sailer wrote:
> > > On Sun, 2006-08-06 at 14:10 -0700, Randy.Dunlap wrote:
> > >
> > > > It was just posted to the linux-pci m-l on Aug-04 and has not
> > > > been acted on.
> > >
> > > I'm a bit worried that just storing a gzipped file as usb.ids will
> > > confuse users. Storing it as usb.ids.gz would make it more clear that it
> > > is a compressed file, but would require usbutils to probe for both
> > > usb.ids and usb.ids.gz. What is the stance pciutils takes on that issue?
> > >
> >
> > I have just check the patch for pciutils, it uses pci.ids.gz, but only
> > probes for pci.ids.gz (and not pci.ids) when gzip support is activated.
> >
> > I will redo my patch to support both usb.ids and usb.ids.gz when gzip
> > support is activated. Please expect a few days for that, it will depends
> > if I am able to easily get an Internet connection in the next few days.
> >
>
> Please find attached a new version of the patch. It now checks for
> ./usb.ids.gz, ./usb.ids, @datadir@/usb.ids.gz and @datadir@/usb.ids (in that
> order) when gzip support is activated, and for ./usb.ids and
> datadir/usb.ids when gzip support is not activated.
>
> I have changed USBIDS_FILE into USBIDS_DIR, so that the name of the file
> can be passed in the .c file.
>
> BTW, I am wondering about checking for ./usb.ids{,.gz}. I understand it
> is very useful for debugging purpose while developing, but I am not
> really sure it is useful in the final version that are in the
> distributions. It just opens the usb.ids file of the current directory,
> which can be for example an old version downloaded to /tmp. If a user
> don't know about this feature (and even if it is written in the doc,
> he/she won't read it), he/she could have unexpected result. Well that's
> just my opinion.
Hi,
1. Makefile.am still uses USBIDS_FILE instead of USBIDS_DIR.
(easy to fix)
2. lsusb.c and names.c check for #ifdef HAVE_LIBZ.
What sets that for .c compiles?
What do I need to have installed to get HAVE_LIBZ set?
I'm pretty sure that I have it installed but I'm not seeing
HAVE_LIBZ being defined. (I have zlib & zlib-devel,
both 32-bit and 64-bit versions.)
I want to test the new code in both cases but can't do that yet.
Thanks,
---
~Randy
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
