From: Mike Isely <[EMAIL PROTECTED]>
Rather than directly filling in URB fields, it's safer to use
usb_fill_int_urb(). This improves robustness of the driver; URB
changes in the future will not go uninitialized here. That point not
withstanding, this driver should at least be self-consistent. Either
use usb_fill_int_urb() everywhere or don't bother with it all.
Signed-off-by: Mike Isely <[EMAIL PROTECTED]>
---
This patch series is baselined against vanilla kernel 2.6.18-rc4 plus
the previous patch in this set.
cypress_m8.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff -uprN -X linux-2.6.18-rc4/Documentation/dontdiff
p1/drivers/usb/serial/cypress_m8.c p2/drivers/usb/serial/cypress_m8.c
--- p1/drivers/usb/serial/cypress_m8.c 2006-08-26 12:42:58.000000000 -0500
+++ p2/drivers/usb/serial/cypress_m8.c 2006-08-26 12:45:45.000000000 -0500
@@ -820,9 +820,10 @@ send:
usb_serial_debug_data(debug, &port->dev, __FUNCTION__,
port->interrupt_out_size,
port->interrupt_out_urb->transfer_buffer);
- port->interrupt_out_urb->transfer_buffer_length = actual_size;
- port->interrupt_out_urb->dev = port->serial->dev;
- port->interrupt_out_urb->interval = priv->write_urb_interval;
+ usb_fill_int_urb(port->interrupt_out_urb, port->serial->dev,
+ usb_sndintpipe(port->serial->dev,
port->interrupt_out_endpointAddress),
+ port->interrupt_out_buffer, port->interrupt_out_size,
+ cypress_write_int_callback, port, priv->write_urb_interval);
result = usb_submit_urb (port->interrupt_out_urb, GFP_ATOMIC);
if (result) {
dev_err(&port->dev, "%s - failed submitting write urb, error
%d\n", __FUNCTION__,
--
| Mike Isely | PGP fingerprint
Spammers Die!! | | 03 54 43 4D 75 E5 CC 92
| isely @ pobox (dot) com | 71 16 01 E2 B5 F5 C1 E8
| |
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
