On Thu, 28 Sep 2006, Andrew Morton wrote:
> On Thu, 28 Sep 2006 08:49:52 +0200
> Olaf Hering <[EMAIL PROTECTED]> wrote:
>
> > On Wed, Sep 27, Greg KH wrote:
> >
> > > @@ -372,6 +379,15 @@ struct usb_device {
> > >
> > > int maxchild; /* Number of ports if hub */
> > > struct usb_device *children[USB_MAXCHILDREN];
> > > +
> > > +#ifdef CONFIG_PM
> > > + struct work_struct autosuspend; /* for delayed autosuspends */
> > > + struct mutex pm_mutex; /* protects PM operations */
> > > + int pm_usage_cnt; /* usage counter for autosuspend */
> > > +
> > > + unsigned auto_pm:1; /* autosuspend/resume in progress */
> > > + unsigned do_remote_wakeup:1; /* remote wakeup should be enabled */
> > > +#endif
> >
> > This fails for CONFIG_PM=n.
> > Why did -mm not catch this?
>
> -mm did catch it, and -mm reported it loudly. I had a nasty hack in there
> (fix-gregkh-usb-usbcore-add-autosuspend-autoresume-infrastructure.patch) to
> fix things up, but it got forgotten about.
>
> Alan came up with an alternate patch this week (and then another one) which
> I've
> queued, but Greg hasn't picked it up yet.
As Greg mentioned, it has now been added to his tree. If you want the
original patch to apply for yourself, here it is:
http://marc.theaimsgroup.com/?l=linux-usb-devel&m=115929663530629&w=2
Alan Stern
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
