Am Freitag, 6. Oktober 2006 06:16 schrieb Dmitry Torokhov:
> On Monday 02 October 2006 19:25, Oliver Neukum wrote:
> > Am Dienstag, 3. Oktober 2006 01:12 schrieb Pete Zaitcev:
> >
> > > I do not remember the precise chain of reasoning now, but IIRC our input
> > > open methods must not return non-zero codes (even though they are defined
> > > to return error codes). It has something to do with the way input layer
> > > is coded. So, it's a GOOD thing that you forgot to use 'rv' after it
> > > was set to -EIO.
> >
> > It seem that input_open_device()'s return values are ignored.
> > Coding after midnight is something I simply shouldn't do.
> >
> > On philosophical reason, I must say that ignoring errors is evil,
> > but I am not going to work through the input layer right now.
> >
>
> The error checking is being added, please report proper error codes
> from within ->open() methids.
With the exception of appletouch (and hid which does extensive error handling)
all drivers under usb/input are clean in that regard.
Regards
Oliver
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
