On 10/6/06, David Brownell <[EMAIL PROTECTED]> wrote: > On Thursday 28 September 2006 12:33 am, Christopher "Monty" Montgomery wrote: > > patch 15: This is a usbaudio fixed necessitated by fixing the isoch > > underrun detection/reporting in ehci. usbaudio playback nominally > > causes one harmless underrun in setup that the usbaudio code doesn't > > currently handle correctly. > > > > Signed-off-by: Christopher "Monty" Montgomery <[EMAIL PROTECTED]> > > I'll NAK this one on the grounds that this is clearly the wrong > place to try fixing this ...
Justify that. > EHCI shouldn't be returning such a > fault code, as the current driver (before any of your patches) > says in the relevant comment. .... The previous driver returned this code! Please nak the entire patchset, or accept this patch. Otherwise, you're placing the user in the position of having alot of suddenly broken software. I understand we're in the middle of a long argument about whether or not random failure is a correct design goal or not, but nacking random patches without any further intervention is going to make things much worse, not better. (eg, refusing this patch is going to break most audio applications that use usbaudio. Just so you know.) Monty ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
