On Tue, Oct 17, 2006 at 08:33:06PM -0400, Adam Kropelin wrote: > On Tue, Oct 17, 2006 at 02:51:09PM -0700, Greg KH wrote: > > From: Grant Grundler <[EMAIL PROTECTED]> > > > > extract() and implement() have brain damaged attempts to handle 32-bit wide > > "fields". > > Brain-damaged though they may be, they sure work with my devices a whole > lot better than your "new and improved" version.
The current ones sure don't work on parisc or mips. > I'm not sure what makes you think there's some magic 24 bit limit. I see no > limit specified, although in practice I've never seen anything larger than > 32 bits. The size of a report field (in bits) is set by the Report Size > global item, the data portion of which can be at most a 32 bit integer, > thus giving a maximum field width of 4 Gbits. Clearly taking it that far > would be insane, but limiting it to 24 bits arbitrarily is equally nuts. > > I can send report descriptors of devices in my possession which have 32 > bit wide fields. I'm the guy who patched the original extract() from > "& ((1 << n)" to "& ((1ULL << n)" precisely because it didn't work on > such devices, a bug which you've kindly recreated. It certainly would have helped if you'd commented on this patch the first dozen times it was posted over the last couple of years. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
