On Friday 10 November 2006 5:13 am, Vitaly Wool wrote:
> Hello folks,
> the patch inlined below makes the driver's name less generic to avoid
> possible confusion in future, as was requested by Russell King.

Actually, a better name would match the module:  "ohci-hcd".  And I
see no particular reason not to use that; it's not like it's going
to be usable with some non-OHCI driver, after all!

For any platform_driver, the driver.name should match the module name.
The only exception being if you add a MODULE_ALIAS(driver.name) ...
otherwise, the hotplug/coldplug support ($MODALIAS, /sys/.../modalias)
won't work correctly.

- Dave



>  drivers/usb/host/ohci-pnx4008.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Signed-off-by: Vitaly Wool <[EMAIL PROTECTED]>
> 
> Index: linux-2.6.18/drivers/usb/host/ohci-pnx4008.c
> ===================================================================
> --- linux-2.6.18.orig/drivers/usb/host/ohci-pnx4008.c
> +++ linux-2.6.18/drivers/usb/host/ohci-pnx4008.c
> @@ -454,7 +454,7 @@ static int usb_hcd_pnx4008_remove(struct
>  
>  static struct platform_driver usb_hcd_pnx4008_driver = {
>       .driver = {
> -             .name = "usb-ohci",
> +             .name = "pnx4008-usb-ohci",
>       },
>       .probe = usb_hcd_pnx4008_probe,
>       .remove = usb_hcd_pnx4008_remove,
> 
> 

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to