On Thu, 23 Nov 2006 04:37:59 -0500, Ben Gamari <[EMAIL PROTECTED]> wrote:

> Isn't copy_from_buf supposed to return "an error code, not an offset"?
> Look at line 232  (return off;). I think it should probably return
> 0. Addiionally, I don't think that the while loop in mon_bin_read 
> (line 636) is supposed to be negated. I have also merged the patch 
> with 2.6.19-rc6. [.]

Thanks, Ben, I applied your fixes. The wrong while() loop occurs in
two places. I am thinking about farming it out into a procedure.

-- Pete

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to