On Thu, Nov 23, 2006 at 03:37:08PM +0000, Alan wrote:
> A small number of USB serial drivers are intercepting TCGETS/TCSETS
> ioctls. All of those that do this are broken. 
> 
> Specifically
>       mos7840.c
>       kl5kusb105.c
>       kobil_sct.c
>       cypress_m8.c
> 
> I would be greatful if the maintainers of those drivers fix them. Both
> the tty layer and USB serial provide a ->set_termios() method and that is
> the only correct way to handle termios changes.
> 
> If the maintainers don't fix them then I'll remove the offending code from
> these drivers except for the kobil_sct one. As far as I can tell the
> other drivers don't need the code and will work fine with it removed. The
> kobil_sct needs reworking to use ->set_termios() and if its not fixed
> will get marked && BROKEN.

Yes, everything except kobil_sct can just have those ioctls removed, and
yes, I don't mind the kobil_sct driver being marked broken until it is
fixed for this.

thanks,

greg k-h

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to