Oleg Verych wrote: > On 2006-11-17, Sergey Vlasov wrote: > [] >>> USB Storage: this patch adds support for Sony Ericsson P990i >> This patch has been already merged 4 (!) times - I have submitted a patch >> to kill 3 useless copies of this entry. And now you try to add more... >> Some script has gone mad? > > Yea! Even with crappy e-mail address.... IMO comments are for > documenting code, all credits now are stored in git logs. See today's > message from Linus about this. > > I wish some day all this static useless id-ification will went to > userspace.
Actually - when dealing with blacklists and special-case tables like this, knowing who reported the error is really important and often needs to be easily available... and is often not propogated up in anyway other than that comment or in the large contents of the log for the patch... Often I think it's safe to remove entries based on more robust code and I want to email as many users as possible to get test cases... I don't think a one-line comment is really such a big deal. -- Phil Dibowitz [EMAIL PROTECTED] Freeware and Technical Pages Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel