On Fri, 2006-12-08 at 22:06 -0800, David Brownell wrote: > I'm saying that putting chip-specific workarounds in core driver code > is less attractive than sticking them in bus glue that's specific to > that chip ... especially in cases like this, where the workaround is > essentially writing a register the boot loader ought to have written. > > Look at it this way: you're proposing to modify three different > instances of bus glue to set a flag, AND modifying the core to > write a register in response to that flag. Surely it's much more > straightforward just to have the bus glue write that register > directly? It's a bit less code overall (no core updates); plus, > if that register gets written more conventionally (bootloader) on > some instance of that Cell platform, no quirk will be needed.
Note that for PCI representation (toshiba/ibm), we do have a quirk already to set the right endian bits (see the patches I posted yesterday). We can easily add writing of the magic RH registers there too. As for PS3, that can indeed be done from the special bus glue. Ben. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
