Am Freitag, 12. Januar 2007 07:11 schrieb Greg KH: > On Tue, Jan 09, 2007 at 11:51:18AM -0800, J wrote: > > Hi, > > > > During the last few days me and Oliver Neukum > > exchanged some messages about fixing the usb-serial.c. > > We came to an agreement and I made a patch > > (which should be applied after 3 patches, which > > were posted by Oliver on 1/2/07 at > > linux-usb-devel@lists.sourceforge.net) > > > > We agreed that usb-serial had the following errors: > > 1) serial table is not protected by locks. > > kref_get() may be called on freed memory > > 2) probe() exposes uninitialized devices > > 3) disconnect() does not make sure there's no more IO > > to unbound devices > > 4) try_module_get() is called with unprotected > > pointers > > 5) there's a race between write() and disconnect() > > > > Oliver fixed most of these issues in 1/2/07 patch. > > Hm, I never applied that, as I didn't know it should have been. Anyone > care to resubmit it with the proper headers? > > Also, these patches don't have descriptions and the correct patch level. > Care to redo that?
They were just for review and not application and clearly marked so. I have no device to test this on and the changes are quite large. I would like to know that they have been tested before inclusion, but I'll redo them. Regards Oliver ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel