On Friday 12 January 2007 2:12 pm, Alan Stern wrote: > On the other hand, I did find (another) bug in the async I/O handling in > inode.c. If you aren't using the AIO code in usb.c then it shouldn't > affect you, but you might want to give it a try anyway.
Alan, could you explain what the bug here is? ISTR that the policy for those retry routines is to always put the request. I know that you removed that some time ago, and that it re-appeared with a recent update to change the AIO interface ... but the original code had no leaks, and this change seems likely to create one. (Unless the AIO core changed incompatibly ... but I'd have expected that the person who updated this code to reflect the "new" API would get that right.) - Dave > Alan Stern > > > Index: usb-2.6/drivers/usb/gadget/inode.c > =================================================================== > --- usb-2.6.orig/drivers/usb/gadget/inode.c > +++ usb-2.6/drivers/usb/gadget/inode.c > @@ -586,7 +586,6 @@ static ssize_t ep_aio_read_retry(struct > } > kfree(priv->buf); > kfree(priv); > - aio_put_req(iocb); > return len; > } > > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
