On Thu, 22 Feb 2007, Greg KH wrote: > On Fri, Feb 09, 2007 at 05:08:48PM -0500, Alan Stern wrote: > > This patch (as853) cleans up the new USB blacklist code in several > > ways: > > > > Replace the STRING_FETCH quirk with STRING_FETCH_255, > > meaning not to use a 255-byte query when retrieving > > string descriptors. This is all that the problem-causing > > HP scanners require. > > > > Improve some comment texts. > > > > Don't log the quirks value if it is 0. > > > > Make sysfs display the quirks value in hexadecimal, which > > will be more informative. > > > > Signed-off-by: Alan Stern <[EMAIL PROTECTED]> > > I've merged this in, thanks. > > But is the blacklist still needed with the autosuspend stuff you have > added? > > Oh wait, we do more than just autosuspend things in there, I guess so, > nevermind... > > But should I pull the autosuspend entry out of there for the Blackberry? > I could just modify the autosuspend value in the blackberry driver > before it decides to not bind to the device, right?
That would be cleaner. If somebody didn't have the blackberry driver installed then they wouldn't see any unexpected behavior. The blacklist flag was really intended for devices which can't handle being suspended. The Blackberry can handle it okay, but just can't recharge while it is suspended. That's a separate issue, which doesn't belong in the blacklist. Alan Stern ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
