On Friday 20 April 2007 8:33 am, Alan Stern wrote:
> This patch (as901) fixes an oversight in ohci-hcd.  The
> hub_status_data routine must not try to access the controller's
> memory-mapped registers if the controller is in a low-power state;
> such attempts will cause a crash on some architectures (such as PPC).
> 
> Signed-off-by: Alan Stern <[EMAIL PROTECTED]>

Acked-by: David Brownell <[EMAIL PROTECTED]>

> 
> ---
> 
> Index: usb-2.6/drivers/usb/host/ohci-hub.c
> ===================================================================
> --- usb-2.6.orig/drivers/usb/host/ohci-hub.c
> +++ usb-2.6/drivers/usb/host/ohci-hub.c
> @@ -417,6 +417,8 @@ ohci_hub_status_data (struct usb_hcd *hc
>       unsigned long   flags;
>  
>       spin_lock_irqsave (&ohci->lock, flags);
> +     if (!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags))
> +             goto done;
>  
>       /* undocumented erratum seen on at least rev D */
>       if ((ohci->flags & OHCI_QUIRK_AMD756)
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> linux-usb-devel@lists.sourceforge.net
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
> 

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to