On Tue, 24 Jul 2007 18:18:04 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote:
> > > static int usb_start_wait_urb(struct urb *urb, int timeout, int
> > > *actual_length)
> > > {
> > > - int status = urb->status;
> > > retval = usb_submit_urb(urb, GFP_NOIO);
> >
> > Oh. My. God.
>
> I'm not quite sure what to make of your reaction. :-) Let's see what
> Greg has to say...
>
> Actually, callback structures like this are not at all uncommon. So
> you shouldn't worry that it looks a little awkward.
Your new solution is fine, I think. I was concerned that I missed
something so obvious. I rescanned the patch-2.6.23-rc1 looking for
->status being used _outside_ of a callback and didn't see anything
else, but now I can't be sure we're clear.
It was a good thing that Pavel tracked upstream closely.
-- Pete
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
