-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Fri, 21 Feb 2003 09:50, Howard Shane wrote:
> Hi all,
> I would really like some help deciphering the following error message
> since I'm in the process of composing a Motorola Cable Modem HOWTO for
> TLDP. I'm using the CDCEther driver for a Motorola Surfboard 4100 cable
> modem connected by usb-ohci. Most of the time it works just fine, but on
> occasion (about once a week) I lose my cable internet connection at the
> same time the error below appears in /var/log/debug:
Can you try the attached patch and please report back?
Brad
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE+VcZFW6pHgIdAuOMRAp1UAJ4ozkTgeaUI2cbfktdbK5chBvmBPwCeNTLH
NZJp7PIar7wEDx6uyl9oQ/w=
=d6GD
-----END PGP SIGNATURE-----
diff -Naur -X dontdiff linux-2.4.20-pre11-clean/drivers/usb/CDCEther.c linux-2.4.20-pre11/drivers/usb/CDCEther.c
--- linux-2.4.20-pre11-clean/drivers/usb/CDCEther.c 2002-10-18 09:57:03.000000000 +1000
+++ linux-2.4.20-pre11/drivers/usb/CDCEther.c 2002-10-18 09:23:48.000000000 +1000
@@ -306,22 +306,8 @@
static int CDCEther_start_xmit( struct sk_buff *skb, struct net_device *net )
{
ether_dev_t *ether_dev = net->priv;
- int count;
int res;
- // If we are told to transmit an ethernet frame that fits EXACTLY
- // into an integer number of USB packets, we force it to send one
- // more byte so the device will get a runt USB packet signalling the
- // end of the ethernet frame
- if ( (skb->len) ^ (ether_dev->data_ep_out_size) ) {
- // It was not an exact multiple
- // no need to add anything extra
- count = skb->len;
- } else {
- // Add one to make it NOT an exact multiple
- count = skb->len + 1;
- }
-
// Tell the kernel, "No more frames 'til we are done
// with this one.'
netif_stop_queue( net );
@@ -336,7 +322,10 @@
write_bulk_callback, ether_dev );
// Tell the URB how much it will be transporting today
- ether_dev->tx_urb.transfer_buffer_length = count;
+ ether_dev->tx_urb.transfer_buffer_length = skb->len;
+
+ /* Deal with the Zero Length packet problem, I hope */
+ ether_dev->tx_urb.transfer_flags |= USB_ZERO_PACKET;
// Send the URB on its merry way.
if ((res = usb_submit_urb(ðer_dev->tx_urb))) {
