Am Donnerstag, 16. Juni 2005 13:01 schrieb Petr Pisar:
> Simon Wu napsal(a):
> > Hello,
> >
> > I have a wireless mobile/modem device that uses usbserial driver on
> > linux. The vendor only provide custom driver for windows. The
> > usbserial driver works work when the throughput is about 384k. But
> > when the new modem goes to almost 2Mbps, the linux usbserial driver
> > can only support to up about 400kbps, whilst on windows it goes up to
> > 2Mbps.
> >
> > This issue is on boht 2.4.24 and 2.6.6 kernels.
> >
> > This will impact lots of person because many 3G wireless (CDMA and
> > UMTD) mobiles/modems use this vendor's chipset.
> >
>
> David Kubicek has rewritten cdc-acm module for 2.6 kernel. It is still
> in testing but it seems stable. Patch can be downloaded from
> [http://dave.ok.cz/cdc-acm_release/].
extremely cool and definitely 2.6.13 material
a few remarks:
- if (urb->status)
- dev_dbg(&acm->data->dev, "bulk rx status %d\n", urb->status);
You can't ignore errors.
+ if (!rcv || urb <= 0) {
What is this supposed to do?
+ if ((err = usb_submit_urb(rcv->urb, GFP_ATOMIC)) < 0) {
Can this kill the driver by ENOMEM?
+ for (i = 0; i < ACM_MAX_READ_BUFS; i++) {
+ struct acm_read_buffer *buf = &(acm->read_bufs[i]);
+
+ if (!(buf->base = kmalloc(readsize, GFP_KERNEL))) {
+ dev_dbg(&intf->dev, "out of memory (read_bufs
kmalloc)\n");
+ goto alloc_fail7;
+ }
}
This should alloc usb buffers, not use kmalloc.
Regards
Oliver
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-users
