Hi JE,
I think queueing bulk transfers don't need an extra flag.
I would expect from a pipe that it can queue requests.
If you don't want to queue bulk transfers then just
send one URB.
Otherwise, if we use the USB_QUEUE_BULK flag
I have to do extra work to implement
restrict-to-single-URB transfers on usb-ohci.c :-(
Roman
Johannes Erdfelt wrote:
>
> Another patch:
>
> - Changes all urb_t references to struct urb to make code cleaner
> - Removes native linked list routines for tracking TD's in URB's. Uses
> list_head and list_add_tail now
> - Use list_empty instead of checking pointers
> - Don't delay unlink QH if it wasn't linked in the first place
> - Force interrupt next frame if delaying unlinking of QH and/or URB's
> (Sometimes QH's, and more importantly URB's, would sit around for a
> while before being properly unlinked and the callback being made)
> - Fix deadlock in uhci_destroy_urb_priv. If a seemingly impossible
> set of conditions are met, then we would exit before releasing the
> spinlock, causing a deadlock next time around. I don't think anyone
> ran into this
> - Little bit more error reporting in failure circumstances
> - Use some more macros instead of magic numbers (in shifts, etc)
> - Allow zero length bulk packets. Dunno if this is useful or not
> - Implement USB_QUEUE_BULK support (UNTESTED!)
> - Disallow multiple URB's to one endpoint simultaneously unless using
> USB_QUEUE_BULK
> - Set USB_TIMEOUT_KILLED on a timeout, to inform the client that it was
> unlinked because of a timeout
> - {GET,SET}_INTERFACE support for the virtual root hub (from my userspace
> driver binding patch)
>
> There's a couple of features I haven't tested yet because there are no
> drivers for devices I can get my hands on which utilize them.
>
> Such as timeouts for URB's, USB_QUEUE_BULK and USB_ASYNC_UNLINK. If anyone
> has any drivers (other than dabusb) which utilizes these features, please
> tell me so I can test them out and fix any bugs.
>
> This patch is against 2.3.99-pre4-5.
>
> Randy, please send this to Linus.
>
> JE
>
> ------------------------------------------------------------------------
>
> uhci-je.patchName: uhci-je.patch
> Type: Plain Text (text/plain)
>
> ------------------------------------------------------------------------
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
