On Wed, Apr 12, 2000 at 12:35:43AM +0000, Johannes Erdfelt wrote:
> > > is the completion handler called ?
> > 
> > No, except the urb->transfer_flags have USB_ASYNC_UNLINK set.
> 
> Is this the desired behaviour in the deallocate() call? My driver does
> call the callback.

Oops, I've mixed something up. The completion handler is _always_ called,
but for usb-uhci only in the asynchronous case remaing data is transferred
to transfer_buffer.
If it is desireable to have this also after synchronous unlink, it would be
no problem. But I thought it may confuse some drivers.
 
> > > does it have any effect on the unlinking stuff ?
> > 
> > usb-uhci: Not for the completion stuff, but it may disturb the data toggle
> > ordering if you kill an URB in between. 
> > So please unlink all URBs that are on the way. 
> 
> This is interesting point. I don't track the data toggle for packets
> which have been sent on a forceful unlink.
> 
> Does usb-uhci do that?

Not yet, although it wouldn't be that complicated. But killing queued
URBs is usually a sign of "roof on fire", so the right data toggle may be
the smallest issue...
-- 
        Bye
         Georg Acher, [EMAIL PROTECTED]         
         http://www.in.tum.de/~acher/
          "Oh no, not again !" The bowl of petunias          

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to