On Wed, Apr 12, 2000 at 11:06:37AM +0100, David Woodhouse wrote:
> For a start, drivers/usb/Config.in calls these variables
> CONFIG_INPUT_MOUSEDEV_SCREEN_[XY] while drivers/usb/mousedev.c calls them
> CONFIG_MOUSEDEV_SCREEN_[XY].
Thanks for the bug report - patch attached. It's *anyway* for digitizers
emulating a mouse only, for normal mice the values aren't used.
> But I'm more concerned at their existence in the first place.
They shouldn't exist. Yes. mousedev.c shouldn't exist at all. It'a a
hack to make existing applications work by emulating a PS/2 mouse with
data from various USB devices.
As soon as applications that use mouse will be able to talk to the event
interface implemented by evdev.c, mousedev can go as can these two options.
I already do have a patch for GPM. But I still need someone to write a
XInput module for XFree. Several people promised to do that, but no
results so far.
> Do I really have to recompile my kernel every time I hit
> Ctrl-Alt-{Plus,Minus} to change my X server's screen resolution?
If you use a digitizer and want to have it cover all screen, yes.
> Couldn't we at least make an _attempt_ at getting this information from a
> framebuffer device, or making it configureable at runtime?
Feel free to submit a patch that does this better. Or even better write
(or get someone to write) the XInput module.
> Why's it necessary anyway?
See above. Btw, it's not new in pre-5, it's just been hidden under
another option.
--
To Randy: Please apply the patch.
--
Vojtech Pavlik
SuSE Labs
--- mousedev.c Sun Apr 9 20:08:54 2000
+++ mousedev.new Wed Apr 12 17:20:33 2000
@@ -39,11 +39,11 @@
#include <linux/input.h>
#include <linux/config.h>
-#ifndef CONFIG_MOUSEDEV_SCREEN_X
-#define CONFIG_MOUSEDEV_SCREEN_X 1024
+#ifndef CONFIG_INPUT_MOUSEDEV_SCREEN_X
+#define CONFIG_INPUT_MOUSEDEV_SCREEN_X 1024
#endif
-#ifndef CONFIG_MOUSEDEV_SCREEN_Y
-#define CONFIG_MOUSEDEV_SCREEN_Y 768
+#ifndef CONFIG_INPUT_MOUSEDEV_SCREEN_Y
+#define CONFIG_INPUT_MOUSEDEV_SCREEN_Y 768
#endif
struct mousedev {
@@ -93,12 +93,12 @@
switch (code) {
case ABS_X:
size =
handle->dev->absmax[ABS_X] - handle->dev->absmin[ABS_X];
- list->dx += (value *
CONFIG_MOUSEDEV_SCREEN_X - list->oldx) / size;
+ list->dx += (value *
+CONFIG_INPUT_MOUSEDEV_SCREEN_X - list->oldx) / size;
list->oldx += list->dx * size;
break;
case ABS_Y:
size =
handle->dev->absmax[ABS_Y] - handle->dev->absmin[ABS_Y];
- list->dy -= (value *
CONFIG_MOUSEDEV_SCREEN_Y - list->oldy) / size;
+ list->dy -= (value *
+CONFIG_INPUT_MOUSEDEV_SCREEN_Y - list->oldy) / size;
list->oldy -= list->dy * size;
break;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
