Hi Mark,
I looked at the compiler emitted code for
ov511_move_420_rgb42() and don't see any floating
point in it, as I expected, but I wanted to confirm
this and didn't have time to do so earlier today.
Alan, can you comment on "b." below?
Thanks,
Randy
-----Original Message-----
From: Dunlap, Randy [mailto:[EMAIL PROTECTED]]
Sent: Friday, May 05, 2000 6:02 PM
To: 'Mark McClelland'; Linux-USB
Subject: [linux-usb] RE: [patch] OV511 1.12
Hi Mark,
a. Do you NEED to leave the 2.2-backward compatibility code
in this driver? That's not the way Linus wants to see it
done. The backport should be able to take care of this,
although you may need to work with Vojtech on it.
b. I see that you are using /proc/ov511/video* and cpia uses
/proc/cpia/video*. I thought that drivers were supposed to
use /proc/driver/xxx for proc-fs data like this (or did I
dream that?). Or should v4l drivers use /proc/video/* or
/proc/v4l/* ? Is there any standard^W expectation on this?
c. Is all of the floating point math done at compile
time? It can't stay in there if it's done at run time.
[I just noticed that it was in there previously.]
~Randy
> -----Original Message-----
> From: Mark McClelland [mailto:[EMAIL PROTECTED]]
> Sent: Friday, May 05, 2000 3:26 PM
> To: Linux-USB; Randy Dunlap
> Subject: [patch] OV511 1.12
>
> This is against 2.3.39-pre6 (or later)
>
> CHANGES:
> - The camera detection is now more intelligent and efficient.
> This is an attempt
> to eliminate the "Failed to read sensor ID" problem that many people
> have.
> - Added "i2c_detect_tries" module parameter.
> - OV7610 reg COM_F default changed from 0x90 to 0xA2. Bit 2 must be 1
> according
> to the 7620 spec, and I assume the same here.
> - Added aperture parameter. Values are from 0 - 15 and are sensor
> specific.
> Value is written to the upper nybble of 7610/20 reg COM_F.
> - ov6710_configure() renamed to ov76xx_configure()
> - moved OV511 reg defaults from aRegvalsNorm7610[] to
> aRegvalsNorm511[]
> - moved OV76xx specific code from ov511_configure() to
> ov76xx_configure()
> - added version constant
> - updated memory management functions
> - proc filesystem support added
> - minor changes in ov511_read()
> - ov511_configure() now sets frame->depth and frame->segment;
> this fixed read
> - ov511_probe() modified to use custom ID table
> - ov511.h: PDEBUG updated to print function name and line number
> - ov511.h: Added proc fs vars to usb_ov511
>
> --
> Mark McClelland
> [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
