Hello,
On 15-May-00 Thomas Sailer wrote:
> Here's a new patch that should even choose the
> right altsetting on the Philips cams.
>
> There seems to be an unrelated problem with the
> Philips cams though.
>
> Note that the current code breaks the OSS API
> even for the Philips cam's, Nemsoft was just
> lucky enough not to notice it...
Okay, I've tried the patch and your method of choosing the alt-setting works
with the Philips cams (I even liked how you did it :)). However, it breaks
one thing: the read() (and I suspect the write() calls too) don't work
anymore, they hang. I've traced it down to this snippet of your patch:
--- audio.c.orig Fri May 12 13:05:18 2000
+++ audio.c Mon May 15 18:14:23 2000
@@ -973,6 +988,8 @@
}
spin_lock_irqsave(&as->lock, flags);
}
+ if (u->dma.count <= 0 && !u->dma.mapped)
+ return 0;
u->flags |= FLG_RUNNING;
if (!(u->flags & FLG_URB0RUNNING)) {
urb = &u->durb[0].urb;
@@ -1332,6 +1349,8 @@
}
spin_lock_irqsave(&as->lock, flags);
}
+ if (u->dma.count <= 0 && !u->dma.mapped)
+ return 0;
u->flags |= FLG_RUNNING;
if (!(u->flags & FLG_URB0RUNNING)) {
urb = &u->durb[0].urb;
This is in usbin_start() resp. usbout_start(). I'm not sure what you try to
acclompish here, but it seems that unless the application uses mmap() you
never get to the point of scheduling URBs...
Anyway, the rest of the patch is fine with me.
- Nemosoft
-----------------------------------------------------------------------------
Try SorceryNet! One of the best IRC-networks around! irc.sorcery.net:9000
URL: never IRC: nemosoft IscaBBS (bbs.isca.uiowa.edu): Nemosoft
>> Never mind the daylight <<
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
