Hi Mark,
I just had a change to try updating my driver and had a few problems:
On line 1260, 1.15 shows:
pOut1 += iWidth - WDIV;
I think that WDIV should be 8. In other words:
pOut1 += iWidth - 8;
That's how it is in older versions of the driver and that's what my set up
needs to work in monochrome. Has somebody else found that it should be WDIV
instead of 8 to work????
I see you've added lots of modes. These modes seem to just use however many
pixels from the upper left corner of the image. It seems to me that the
optics would be better if the center of the image were used. Also, there
are 4 mode_list entries for snapshots that are always identical to the
non-snapshot mode. Will they ever vary?
I see you've hacked out subframe support (which was only available in
640x480 anyway). How come? I happen to need that. Can I add it back in as
an if statement for that specific case?
I see you've hacked out timestamp support. How come? I happen to need that
too. And if you're committed to getting rid of that, you probably ought to
not allocate the memory for it.
I see you've added an autoadjust flag. I like that. Is there anyway using
the v4l framework to turn that on and off on the fly? I've added some hacks
that have allowed me to do that, but it violates the specs.
I'm hoping that the things I need can be kept in or added to the driver.
Otherwise, I'll probably be stuck maintaining my own separate version going
forward and won't be able to be much support to linux-usb, either from a
code development or testing standpoint.
Thanks,
Bret
> -----Original Message-----
> From: Mark McClelland [mailto:[EMAIL PROTECTED]]
> Sent: Tuesday, May 23, 2000 5:17 AM
> To: Linux-USB
> Cc: Randy Dunlap; Claudio Matsuoka
> Subject: Re: [linux-usb] [patch] ov511 1.15
>
>
> Forgot to attach the patch; sorry about that. Here it is...
>
> Mark McClelland wrote:
> >
> > This is against 2.3.99-pre9-2 + my 1.14 patch.
> >
> > SUMMARY:
> > o 384x288 and 448x336 modes
> > o better /proc/video support
> >
> > CHANGES:
> > - changed to use /proc/video entry created by videodev.c
> > - 384x288 and 448x336 modes added
> > - ov511_move_data() rewritten
> > - Added debug messages for IOCTLs
> > - Miscellaneous changes in ov511_ioctl()
> > - Documentation/Configure.help: CONFIG_VIDEO_PROC_FS help added
> > - CREDITS: updated
> > - drivers/char/Config.in: CONFIG_VIDEO_PROC_FS option added
> > - drivers/char/videodev.c: procfs support added
> > - Documentation/ov511.txt: updated
>
> --
> Mark McClelland
> [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
