Greg,
I agree with David and Dmitri -- on open().
For some drivers there could be a compelling argument
to do it on probe()...
~Randy
> > The latest patch from Dmitri for the ibmcam reminded me
> that we have two
> > different ways the usb drivers call MOD_INC_USE_COUNT. One group of
> > drivers (ibmcam, keyboard, mice, printer, acm, and other
> input devices)
> > only increment the module use when the device is opened (if
> at all, like
> > the mouse driver).
> >
> > The other drivers increment it when the device is recognized
> > (usb-serial, dabusb, uss720, and others).
> >
> > Which way should it be? On successful probe() or on open()?
>
> My vote is for the open() ... it makes fewest restrictions on
> driver updates.
>
> - Dave
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
