Randy & all,
Thanks to Nicolas Dague I found a sign extension bug in the dsbr100
radio driver. There is a patch in the attachment. (The only code line
changed is an "unsigned" before the char transfer_buffer declaration).
How I wish ANSI had specified whether the default char was signed or
unsigned...
Markus
----------------------------------
[EMAIL PROTECTED]
finger me as [EMAIL PROTECTED]
--- dsbr100-old.c Tue May 30 16:17:14 2000
+++ dsbr100.c Sat Jun 3 13:07:40 2000
@@ -33,16 +33,18 @@
History:
+ Version 0.22: (md) Fixed silly signedness bug
+
Version 0.21:
- Markus Demleitner <[EMAIL PROTECTED]>:
- Minor cleanup, warnings if something goes wrong, lame attempt
+ (md) Minor cleanup, warnings if something goes wrong, lame attempt
to adhere to Documentation/CodingStyle
Version 0.2:
Brad Hards <[EMAIL PROTECTED]>: Fixes to make it work as non-module
- Markus: Copyright clarification
+ Copyright clarification (md)
- Version 0.01: Markus: initial release
+ Version 0.01: Markus Demleitner <[EMAIL PROTECTED]> (md):
+ initial release
*/
@@ -77,7 +79,7 @@
typedef struct
{ struct urb readurb,writeurb;
struct usb_device *dev;
- char transfer_buffer[TB_LEN];
+ unsigned char transfer_buffer[TB_LEN];
int curfreq;
int stereo;
int ifnum;
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
