On Fri, Jul 07, 2000 at 05:15:02PM +0200, Benjamin Herrenschmidt wrote:
> > - should hid.c be fixed to use USB_ASYNC_UNLINK ? (and potentially other
> >drivers). In this case, I beleive this should be documented with a big
> >warning, or eventually add a test of in_interrupt() in usb_unlink_urb()
> >displaying a big error when this flag is not set so at least we know
> >what's going on and driver writers using UHCI will fix their bugs ;)
>
> Note that in any case, I beleive we should flip flop between two urbs in
> hid.c to avoid this case and use async unlink when the "other" urb is
> available, and sync unlink only when both are busy. This way, we would
> probably reduce the potential of causing quite huge latencies in the
> kernel at interrupt time (1ms at least for example in the uhci driver)
Get a newer version, this was fixed quite long ago.
--
Vojtech Pavlik
SuSE Labs
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
