Am Freitag, 1. Februar 2008 20:23:22 schrieb Tobias Lorenz:
> Hi Oliver,
>
> > + mutex_lock(&radio->lock);
> > + mutex_unlock(&radio->lock);
>
> You are adding a lot of mutexes around si470x rds register accesses, which I
> don't think is necessary.
> Parallel accesses to the registers will never harm anything or cannnot cause
> any data corruption.
> I used radio->lock just for RDS buffer modifications, so multiple read/write
> attempts do not interfere.
The locks are added so that the delayed work is reliably cancelled during
shutdown(). Thanks for testing.
Regards
Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
