On 08/22/2012 01:44 AM, Arnd Bergmann wrote: > On Wednesday 22 August 2012, Tony Prisk wrote: >> The original patch was very simple, but I revisited it to fix other >> issues and forgot to add the relevant comments. >> >> Port size is changed to fix a problem - WM8505 actually had 6 uart's >> defined in platform data but the vt8500_ports variable was only 4. >> >> I have added devicetree port id support as well. > > If you do multiple things in one driver, you should normally send multiple > patches as well, each with a description why that change is done. > It may seem silly at first to send out a one-line patch next to a 100-line > patch for the same file, but those cases are actually the ones where it's > most important.
Think of us poor git-bisect monkeys who have no idea why something broke but can (purely mechanically) figure out which commit did it. If it's a patch that does three unrelated things, we're kinda stuck. Rob -- GNU/Linux isn't: Linux=GPLv2, GNU=GPLv3+, they can't share code. Either it's "mere aggregation", or a license violation. Pick one. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
