On Tue, 9 Oct 2012 11:06:52 -0400 (EDT), Alan Stern <st...@rowland.harvard.edu>
wrote :
> On Tue, 9 Oct 2012, Anisse Astier wrote:
>
> > BIOS vendors keep changing the BIOS versions. Only match the beginning
> > of the string to match all Lucid tablets with board name M11JB.
> >
> > Signed-off-by: Anisse Astier <ani...@astier.eu>
> > Cc: <sta...@vger.kernel.org>
> > ---
> > drivers/usb/host/pci-quirks.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> > index 966d148..ead4525 100644
> > --- a/drivers/usb/host/pci-quirks.c
> > +++ b/drivers/usb/host/pci-quirks.c
> > @@ -545,7 +545,7 @@ static const struct dmi_system_id __devinitconst
> > ehci_dmi_nohandoff_table[] = {
> > /* Pegatron Lucid (Ordissimo AIRIS) */
> > .matches = {
> > DMI_MATCH(DMI_BOARD_NAME, "M11JB"),
> > - DMI_MATCH(DMI_BIOS_VERSION, "Lucid-GE-133"),
> > + DMI_MATCH(DMI_BIOS_VERSION, "Lucid-"),
> > },
> > },
>
> How about matching any BIOS from Lucid, regardless of the board name?
I was just being conservative. Lucid is a common english word, and you
never know how another company could name their BIOS. Or maybe pegatron
could decide to fix their BIOS on different boards.
I personally have no objection if you think it won't step on other
people's toes.
>From 2bed60970be0aaca863cd18fbaa4d3b6a068192f Mon Sep 17 00:00:00 2001
From: Anisse Astier <ani...@astier.eu>
Date: Tue, 9 Oct 2012 17:31:44 +0200
Subject: [PATCH] ehci: make pegatron lucid nohandoff dmi quirk more generic
Any board that has Lucid- in its bios version is considered to be a
Pegatron Lucid tablet. This should help diminish the number of dmi
entries for this quirk.
Suggested-by: Alan Stern <st...@rowland.harvard.edu>
Signed-off-by: Anisse Astier <ani...@astier.eu>
Cc: <sta...@vger.kernel.org>
---
drivers/usb/host/pci-quirks.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index 966d148..9a20509 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -535,17 +535,9 @@ static void __devinit quirk_usb_handoff_ohci(struct
pci_dev *pdev)
static const struct dmi_system_id __devinitconst ehci_dmi_nohandoff_table[] = {
{
- /* Pegatron Lucid (ExoPC) */
+ /* All Pegatron Lucid based tablets (ExoPC, Ordissimo) */
.matches = {
- DMI_MATCH(DMI_BOARD_NAME, "EXOPG06411"),
- DMI_MATCH(DMI_BIOS_VERSION, "Lucid-CE-133"),
- },
- },
- {
- /* Pegatron Lucid (Ordissimo AIRIS) */
- .matches = {
- DMI_MATCH(DMI_BOARD_NAME, "M11JB"),
- DMI_MATCH(DMI_BIOS_VERSION, "Lucid-GE-133"),
+ DMI_MATCH(DMI_BIOS_VERSION, "Lucid-"),
},
},
{ }
--
1.7.12.3
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
