> -----Original Message-----
> From: Rob Herring [mailto:[email protected]]
> Sent: 2018年3月3日 6:29
> To: Jun Li <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; Peter Chen <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; dl-linux-imx <[email protected]>
> Subject: Re: [PATCH v2 10/12] dt-bindings: connector: add properties for
> typec power delivery
>
> On Mon, Feb 26, 2018 at 07:49:17PM +0800, Li Jun wrote:
> > In case of usb-c-connector with power delivery support, add bingdings
> > supported by current typec driver, so user can pass all those
> > properties via dt.
> >
> > Signed-off-by: Li Jun <[email protected]>
> > ---
> > Changes for v2:
> > - Added typec properties are based on general usb connector bindings[1]
> > proposed by Andrzej Hajda.
> > - Use the standard unit suffixes as defined in property-units.txt.
> >
> > [1]
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
> >
> chwork.kernel.org%2Fpatch%2F10231447%2F&data=02%7C01%7Cjun.li%40
> nxp.co
> >
> m%7C1741037c725343583b2c08d5808d034c%7C686ea1d3bc2b4c6fa92cd9
> 9c5c30163
> >
> 5%7C0%7C0%7C636556265503496434&sdata=AlR4ybLfxkAedHJCYQtlD%2B
> OXLEOAcbs
> > olMZumioKKNk%3D&reserved=0
> >
> > .../bindings/connector/usb-connector.txt | 43
> ++++++++++++++++++++++
> > 1 file changed, 43 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/connector/usb-connector.txt
> > b/Documentation/devicetree/bindings/connector/usb-connector.txt
> > index e1463f1..242f6df 100644
> > --- a/Documentation/devicetree/bindings/connector/usb-connector.txt
> > +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
> > @@ -15,6 +15,30 @@ Optional properties:
> > - type: size of the connector, should be specified in case of USB-A, USB-B
> > non-fullsize connectors: "mini", "micro".
> >
> > +Required properties for usb-c-connector with power delivery support:
> > +- port-type: should be one of "source", "sink" or "dual".
> > +- default-role: preferred power role if port-type is "dual"(drp),
> > +should be
> > + "sink" or "source".
> > +- src-pdos: An array of u32 with each entry providing supported power
> > + source data object(PDO), the detailed bit definitions of PDO can be
> > +found
> > + in "Universal Serial Bus Power Delivery Specification" chapter
> > +6.4.1.2
> > + Source_Capabilities Message, the order of each entry(PDO) should
> > +follow
> > + the PD spec chapter 6.4.1. Required for power source and power dual
> role.
> > +- snk-pdos: An array of u32 with each entry providing supported power
>
> Abbreviating sink to snk doesn't buy much. I'd also just do source instead of
> src.
Will use source/sink-pdos in next version.
>
> > + sink data object(PDO), the detailed bit definitions of PDO can be
> > +found in
> > + "Universal Serial Bus Power Delivery Specification" chapter 6.4.1.3
> > +Sink
> > + Capabilities Message, the order of each entry(PDO) should follow
> > +the PD
> > + spec chapter 6.4.1. Required for power sink and power dual role.
> > +- max-snk-microvolt: The max voltage the sink can support in micro
> > +volts,
> > + required for power sink and power dual role.
> > +- max-snk-microamp: The max current the sink can support in micro
> > +amps,
> > + required for power sink and power dual role.
> > +- max-snk-microwatt-hours: The max power the sink can support in
> > +micro
> > + Watt-hours, required for power sink and power dual role.
> > +- op-snk-microwatt-hours: Sink required operating power in micro
> > +Watt-hours,
> > + if source offered power is less then it, Capability Mismatch is
> > +set,
> > + required for power sink and power dual role.
>
> None of these properties are part of the PDO?
Sorry, all above 4 props are not required any more with latest code,
I will remove them.
Jun Li
N�Р骒r��y����b�X�肚�v�^�)藓{.n�+�伐�{焙柒��^n�r■�z���h�ㄨ��&Ⅷ �G���h�(�����茛j"���m����赇z罐��帼f＂�h���~�m�
