Hi, > -----Original Message----- > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Heikki Krogerus > Sent: 2018年3月6日 20:33 > To: Hans de Goede <hdego...@redhat.com> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>; Guenter Roeck > <li...@roeck-us.net>; linux-usb@vger.kernel.org; Badhri Jagan Sridharan > <bad...@google.com> > Subject: Re: [PATCH 4.16 REGRESSION fix] Revert "typec: tcpm: Only request > matching pdos" > > On Tue, Mar 06, 2018 at 10:50:05AM +0100, Hans de Goede wrote: > > Commit 57e6f0d7b804 ("typec: tcpm: Only request matching pdos") is > > causing a regression, before this commit e.g. the GPD win and GPD > > pocket devices were charging at 9V 3A with a PD charger, now they are > > instead slowly discharging at 5V 0.4A, as this commit causes the > > ports max_snk_mv/ma/mw settings to be completely ignored. > >
So max_snk_mv/ma/mw settings are back, I am dealing with PD properties definition, so want to ask for long term, should we keep them, or use the reverting patch way(only compare sink PDOs Vs source PDOs) but fix the problem with it. Thanks Jun Li > > Arguably the way to fix this would be to add a PDO_VAR() describing > > the voltage range to the snk_caps of boards which can handle any > > voltage in their range, but the "typec: tcpm: Only request matching > > pdos" commit looks at the type of PDO advertised by the source/charger > > and if that is fixed (as it typically is) only compairs against > > PDO_FIXED entries in the snk_caps so supporting a range of voltage > > would require adding a PDO_FIXED entry for *every possible* voltage to > snk_caps. > > > > AFAICT there is no reason why a fixed source_cap cannot be matched > > against a variable snk_cap, so at a minimum the commit should be > > rewritten to support that. > > > > For now lets revert the "typec: tcpm: Only request matching pdos" > > commit, fixing the regression. > > > > Cc: Badhri Jagan Sridharan <bad...@google.com> > > Signed-off-by: Hans de Goede <hdego...@redhat.com> > > You are correct. The patch should be rewritten. > > Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> > > > Thanks, > > -- > heikki > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in the > body > of a message to majord...@vger.kernel.org More majordomo info at > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.k > ernel.org%2Fmajordomo-info.html&data=02%7C01%7Cjun.li%40nxp.com%7C > 6cd4e7a122244982de5e08d5835e618c%7C686ea1d3bc2b4c6fa92cd99c5c30 > 1635%7C0%7C0%7C636559363813086942&sdata=nZw4ta%2Frro44iG%2FfH > bhUrhOKZBdE16JvgSYUsb71qzg%3D&reserved=0
