On Sun, Mar 11, 2018 at 07:24:18PM +0100, Hans de Goede wrote: > Hi all, > > On 09-03-18 18:53, Greg Kroah-Hartman wrote: > > On Fri, Mar 02, 2018 at 11:20:46AM +0100, Hans de Goede wrote: > > > From: Heikki Krogerus <heikki.kroge...@linux.intel.com> > > > > > > Several frameworks - clk, gpio, phy, pmw, etc. - maintain > > > lookup tables for describing connections and provide custom > > > API for handling them. This introduces a single generic > > > lookup table and API for the connections. > > > > > > The motivation for this commit is centralizing the > > > connection lookup, but the goal is to ultimately extract the > > > connection descriptions also from firmware by using the > > > fwnode_graph_* functions and other mechanisms that are > > > available. > > > > > > Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> > > > Reviewed-by: Hans de Goede <hdego...@redhat.com> > > > Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> > > > Signed-off-by: Hans de Goede <hdego...@redhat.com> > > > > Sorry for the delay, just now reviewing this patch... > > > > The content is fine (if not scary for the obvious reason of passing > > around 'struct device' of different bus types, but ok...), but the api > > naming is "rough": > > Heikki, I think it is best if you answer Greg's remarks. FWIW I'm > fine with the changes Greg proposes.
Me too. > I currently have significantly less bandwidth for this due to > personal circumstances, so if a new version of this patch-set > is necessary it would be great if you (Heikki) can do a v7. Sure thing. I'll prepare the v7. Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html