> -----Original Message----- > From: Jun Li > Sent: 2018年3月20日 10:29 > To: Mats Karrman <mats.dev.l...@gmail.com>; robh...@kernel.org; > mark.rutl...@arm.com; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com > Cc: a.ha...@samsung.com; li...@roeck-us.net; yue...@google.com; > shufan_...@richtek.com; o_leve...@orange.fr; linux-usb@vger.kernel.org; > dl-linux-imx <linux-...@nxp.com> > Subject: RE: [PATCH v3 02/12] dt-bindings: usb: add documentation for typec > port controller(TCPCI) > > Hi > > -----Original Message----- > > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > > Sent: 2018年3月15日 23:54 > > To: Jun Li <jun...@nxp.com>; robh...@kernel.org; mark.rutl...@arm.com; > > gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com > > Cc: a.ha...@samsung.com; li...@roeck-us.net; yue...@google.com; > > shufan_...@richtek.com; o_leve...@orange.fr; > > linux-usb@vger.kernel.org; dl-linux-imx <linux-...@nxp.com> > > Subject: Re: [PATCH v3 02/12] dt-bindings: usb: add documentation for > > typec port controller(TCPCI) > > > > Hi, > > > > On 2018-03-13 10:34, Li Jun wrote: > > > > > TCPCI stands for typec port controller interface, its implementation > > > has full typec port control with power delivery support, it's a > > > standard i2c slave with GPIO input as irq interface, detail see spec > > > "Universal Serial Bus Type-C Port Controller Interface Specification > > > Revision 1.0, Version 1.1" > > > > > > Signed-off-by: Li Jun <jun...@nxp.com> > > > --- > > > change for v3: > > > - change compatible string from "usb,tcpci" to be > > > "usb-tcpci,chip-specific-string", update example of it. > > > > > > .../devicetree/bindings/usb/typec-tcpci.txt | 36 > > ++++++++++++++++++++++ > > > 1 file changed, 36 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/typec-tcpci.txt > > > b/Documentation/devicetree/bindings/usb/typec-tcpci.txt > > > new file mode 100644 > > > index 0000000..fe7d2ff > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/usb/typec-tcpci.txt > > > @@ -0,0 +1,36 @@ > > > +TCPCI(Typec port cotroller interface) binding > > > +--------------------------------------------- > > > + > > > +Required properties: > > > +- compatible: should be "usb-tcpci,chip-specific-string". > > > +- reg: the i2c slave address of typec port controller > > > device. > > > +- interrupt-parent: the phandle to the interrupt controller which > > > provides > > > + the interrupt. > > > +- interrupts: interrupt specification for tcpci alert. > > > + > > > +Required sub-node: > > > +- connector: The "usb-c-connector" attached to the tcpci chip, the > > > +bindings > > > + of connector node are specified in > > > + Documentation/devicetree/bindings/connector/usb-connector.txt > > > + > > > +Example: > > > + > > > +ptn5110@50 { > > > + compatible = "usb-tcpci,ptn5110"; > > > + reg = <0x50>; > > > + interrupt-parent = <&gpio3>; > > > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > > > + > > > + usb_con: connector { > > > + compatible = "usb-c-connector"; > > > + label = "USB-C"; > > > + port-type = "dual"; > > > + try-power-role = "sink" > > > + source-pdos = <0x380190c8>; > > > + sink-pdos = <0x380190c8 0x3802d0c8>; > > > + max-sink-microvolt = <9000>; > > > + max-sink-microamp = <2000>; > > > + max-sink-microwatt-hours = <18000>; > > > + op-sink-microwatt-hours = <9000>; > > > > Values should change with suffix, e.g. 9000mV = 9000000uV > > > > Yes, thanks for pointing this out, I will update in v4.
Just realized we are going to remove those properties, see[1]: [1] https://www.spinics.net/lists/linux-usb/msg166986.html anyway thank you for the comments. Jun > > Jun > > > // Mats > > > > > + }; > > > +}; > > >
