On Tue, Mar 12, 2019 at 09:45:27AM -0500, Rob Herring wrote: > On Mon, Mar 11, 2019 at 10:40:09AM +0000, Jun Li wrote: > > Some typec super speed active channel switch can be controlled via > > a GPIO, this binding can be used to specify the switch node by > > a GPIO and the remote endpoint of its consumer. > > > > Signed-off-by: Li Jun <[email protected]> > > --- > > .../devicetree/bindings/usb/typec-switch-gpio.txt | 30 > > ++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/typec-switch-gpio.txt > > b/Documentation/devicetree/bindings/usb/typec-switch-gpio.txt > > new file mode 100644 > > index 0000000..4ef76cf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/typec-switch-gpio.txt > > @@ -0,0 +1,30 @@ > > +Typec orientation switch via a GPIO > > +----------------------------------- > > + > > +Required properties: > > +- compatible: should be set one of following: > > + - "nxp,ptn36043" for NXP Type-C SuperSpeed active switch. > > + > > +- gpios: the GPIO used to switch the super speed active channel, > > Perhaps switch-gpios in case there are other gpios needed. > > > + GPIO_ACTIVE_HIGH: GPIO state high for cc1; > > + GPIO_ACTIVE_LOW: GPIO state low for cc1. > > +- orientation-switch: must be present. > > Why is this needed? The compatible can't imply this?
I think Jun Li is added that based on the comment I put to drivers/usb/typec/mux.c, so I'm to blame here. If we can handle this with the compatible like I guess we can, I'm happy. thanks, -- heikki
