Hi Wolfram, > -----Original Message----- > From: linux-i2c-ow...@vger.kernel.org <linux-i2c-ow...@vger.kernel.org> > On Behalf Of Wolfram Sang > Sent: Friday, June 7, 2019 1:33 AM > To: Ajay Gupta <ajayk...@gmail.com> > Cc: heikki.kroge...@linux.intel.com; linux-usb@vger.kernel.org; linux- > i...@vger.kernel.org; Ajay Gupta <aj...@nvidia.com> > Subject: Re: [PATCH v4 2/5] i2c: nvidia-gpu: add runtime pm support > > > > + pm_runtime_mark_last_busy(i2cd->dev); > > + pm_runtime_put_autosuspend(i2cd->dev); > > Much better to have this only once! > > > +/* > > + * We need gpu_i2c_suspend() even if it is stub, for runtime pm to > > +work > > + * correctly. Without it, lspci shows runtime pm status as "D0" for the > card. > > + * Documentation/power/pci.txt also insists for driver to provide this: > > I'd think the comment up to here is enough and the rest can go. However, I > leave this decision to you. Sure, will fix it.
Thanks > nvpublic
