Re: [PATCH] usb: Replace a < b ? a : b construct with min_t(type, a, b) in adutux driver

[dmg]

Greg KH <gre...@linuxfoundation.org> writes:

>>
>> diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c
>> index 9465fb95d70a..4a9fa3152f2a 100644
>> --- a/drivers/usb/misc/adutux.c
>> +++ b/drivers/usb/misc/adutux.c
>> @@ -379,7 +379,7 @@ static ssize_t adu_read(struct file *file, __user char 
>> *buffer, size_t count,
>>
>>              if (data_in_secondary) {
>>                      /* drain secondary buffer */
>> -                    int amount = bytes_to_read < data_in_secondary ? 
>> bytes_to_read : data_in_secondary;
>> +                    int amount = min_t(size_t, bytes_to_read, 
>> data_in_secondary);
>
> Shouldn't amount and data_in_secondary be of size_t type?  Then you can
> just use min() here, right?


Hi Greg,

sorry,  I saw your comment to the other thread after I sent this one. I
agree. I'll address this issue.

Sorry for the wasted bandwidh, and thank you for the suggestion,

--dmg