Re: [PATCH v2 04/12] usb: gadget: aspeed: Improve debugging when nuking

[Sergei Shtylyov]

On 12.07.2019 12:01, Sergei Shtylyov wrote:

When nuking requests, it's useful to display how many were
actually nuked. It has proven handy when debugging issues
where EP0 went in a wrong state.

Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org>
---
  drivers/usb/gadget/udc/aspeed-vhub/core.c | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c b/drivers/usb/gadget/udc/aspeed-vhub/core.c

index db3628be38c0..0c77cd488c48 100644
--- a/drivers/usb/gadget/udc/aspeed-vhub/core.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/core.c

@@ -65,13 +65,16 @@ void ast_vhub_done(struct ast_vhub_ep *ep, struct ast_vhub_req *req,

  void ast_vhub_nuke(struct ast_vhub_ep *ep, int status)
  {
      struct ast_vhub_req *req;
-
-    EPDBG(ep, "Nuking\n");
+    int count = 0;
      /* Beware, lock will be dropped & req-acquired by done() */
      while (!list_empty(&ep->queue)) {
          req = list_first_entry(&ep->queue, struct ast_vhub_req, queue);
          ast_vhub_done(ep, req, status);
+        count++;
+    }
+    if (count) {
+        EPDBG(ep, "Nuked %d request(s)\n", count);

    CodingStyle says to avoid {} around a single statement.

   I somehow missed this in v1 posting, sorry about that.

      }
  }

MBR, Sergei