[...] > > > +OMAP CONTROL USB > > > + > > > +Required properties: > > > + - compatible: Should be "ti,omap-control-usb" > > > + - reg : Address and length of the register set for the device. It > > > contains > > > + the address of "control_dev_conf" and "otghs_control" or > > > "phy_power_usb" > > > > Could you not use '-' over '_' here? > > that's part of omap hwmod.
Aha, that makes sense (unlike my original comment, now I reread it). Sorry for the noise. > > > + depending upon omap4 or omap5. > > > + - reg-names: The names of the register addresses corresponding to the > > > registers > > > + filled in "reg". > > > + - ti,type: This is used to differentiate whether the control module has > > > + usb mailbox or usb3 phy power. omap4 has usb mailbox in control > > > module to > > > + notify events to the musb core and omap5 has usb3 phy power register > > > to > > > + power on usb3 phy. Should be "1" if it has mailbox and "2" if it has > > > usb3 > > > + phy power. > > > > Why not make this a string property, perhaps values "mailbox" or "register"? > > NAK. Can I ask what your objection to using a string property is? As far as I can see, "ti,type" is only used by this driver, so there's no common convention to stick to. Using a string makes the binding easier for humans to read, and thus harder to mess up in a dts, and it decouples the binding from kernel-side constants. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
