Dear  Greg:

        OK,thank you very much.

Best Regards,
Franko Fang

> -----Original Message-----
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, February 05, 2013 2:39 AM
> To: Fangxiaozhi (Franko)
> Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Xueguiying 
> (Zihan);
> Linlei (Lei Lin); Yili (Neil); Wangyuhua (Roger, Credit); Huqiao (C); 
> ba...@ti.com;
> mdharm-...@one-eyed-alien.net; sebast...@breakpoint.cc
> Subject: Re: [PATCH 1/2] USB: storage: Define a new macro for USB storage
> match rules
> 
> On Mon, Feb 04, 2013 at 03:14:46PM +0800, fangxiaozhi 00110321 wrote:
> > +/* Define the device is matched with Vendor ID and interface
> > +descriptors */ #define UNUSUAL_VENDOR_INTF(id_vendor, cl, sc, pr, \
> > +                   vendorName, productName, useProtocol, useTransport, \
> > +                   initFunction, flags) \
> > +{ \
> > +   .match_flags = USB_DEVICE_ID_MATCH_INT_INFO \
> > +                           | USB_DEVICE_ID_MATCH_VENDOR, \
> > +   .idVendor    = (id_vendor), \
> > +   .bInterfaceClass = (cl), \
> > +   .bInterfaceSubClass = (sc), \
> > +   .bInterfaceProtocol = (pr), \
> > +   .driver_info = (flags) \
> > +}
> 
> I'm not going to reject this given the number of times it has been submitted,
> but can't you use the USB_VENDOR_AND_INTERFACE_INFO() macro here in
> this definition?
> 
> If so, can you send me an add-on patch that makes that change?
> 
> thanks,
> 
> greg k-h

Reply via email to