Hi, On Tue, Feb 12, 2013 at 12:55:18AM -0800, Kuninori Morimoto wrote: > > Hi Felipe > > May I suggest ? > > > we don't need to enable IRQs until we have > > a gadget driver loaded and ready to work, > > so let's delay IRQ enable to ->udc_start() > > and IRQ disable to ->udc_stop(). > > > > While at that, also move the related use of > > request_irq() and free_irq(). > > How about using devm_request_irq() instead of request_irq() ? > Then, free_irq() is not needed
if I do, we will try to request and IRQ which is already request. ->udc_stop() doesn't destroy the underlying struct device * so the IRQ won't be freed. -- balbi
signature.asc
Description: Digital signature
