On Fri, 29 Mar 2013, Lan Tianyu wrote:

> On 2013/3/29 0:50, Alan Stern wrote:
> > On Fri, 29 Mar 2013, Lan Tianyu wrote:
> >
> >> About the path "usb: Add usb port system pm support", do you think it's
> >> ok?
> >
> > Generally yes.  But why doesn't usb_port_system_suspend check for any
> > PM_QOS constraints?  Either on the port itself or on the child device.
> Because usb_port_runtime_suspend() will PM Qos flags. If add check in
> usb_port_system_suspend(), PM Qos flags would be checked twice and
> this seems redundant.

Yes, that's right -- I noticed this the first time I read the patch and 
then forgot it again.

I don't see any other problems with that patch.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to